Cleanest way to put condition inside CodeIgniter ActiveRecord









up vote
0
down vote

favorite












I need to put condition inside CodeIgniter ActiveRecord, here's my code:



public function getData($numb, $period, $status)
$this->db->select("COUNT(*) AS jml")
->from()
->where_not_in();
if($status !== 'all')
$this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

$this->db->where_in()
->group_by("");
return $query = $this->db->get();



I also need to put $period and $numb variables inside where statement. It works, but I don't really like how my code looks like. It looks so dirty. Can you guys give me solution in order to achieve cleaner code? Thanks










share|improve this question

























    up vote
    0
    down vote

    favorite












    I need to put condition inside CodeIgniter ActiveRecord, here's my code:



    public function getData($numb, $period, $status)
    $this->db->select("COUNT(*) AS jml")
    ->from()
    ->where_not_in();
    if($status !== 'all')
    $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

    $this->db->where_in()
    ->group_by("");
    return $query = $this->db->get();



    I also need to put $period and $numb variables inside where statement. It works, but I don't really like how my code looks like. It looks so dirty. Can you guys give me solution in order to achieve cleaner code? Thanks










    share|improve this question























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I need to put condition inside CodeIgniter ActiveRecord, here's my code:



      public function getData($numb, $period, $status)
      $this->db->select("COUNT(*) AS jml")
      ->from()
      ->where_not_in();
      if($status !== 'all')
      $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

      $this->db->where_in()
      ->group_by("");
      return $query = $this->db->get();



      I also need to put $period and $numb variables inside where statement. It works, but I don't really like how my code looks like. It looks so dirty. Can you guys give me solution in order to achieve cleaner code? Thanks










      share|improve this question













      I need to put condition inside CodeIgniter ActiveRecord, here's my code:



      public function getData($numb, $period, $status)
      $this->db->select("COUNT(*) AS jml")
      ->from()
      ->where_not_in();
      if($status !== 'all')
      $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

      $this->db->where_in()
      ->group_by("");
      return $query = $this->db->get();



      I also need to put $period and $numb variables inside where statement. It works, but I don't really like how my code looks like. It looks so dirty. Can you guys give me solution in order to achieve cleaner code? Thanks







      sql-server codeigniter activerecord






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 12 at 0:09









      Hendro Febrian

      517




      517






















          2 Answers
          2






          active

          oldest

          votes

















          up vote
          0
          down vote













          public function getData($numb, $period, $status)
          $this->db->select("COUNT(*) AS jml")
          ->from()
          ->where_not_in()
          ->where_in()
          ->group_by("");
          if($status !== 'all')
          $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

          return $query = $this->db->get();







          share|improve this answer



























            up vote
            0
            down vote













            Utilize double-quote for the overall string and single quotes around the arguments to DATEADD



            $this->db->where("LAYANAN.TGL_LAYANAN 
            BETWEEN DATEADD(`$period`,`$numb`, GETDATE()) AND GETDATE()");





            share|improve this answer




















              Your Answer






              StackExchange.ifUsing("editor", function ()
              StackExchange.using("externalEditor", function ()
              StackExchange.using("snippets", function ()
              StackExchange.snippets.init();
              );
              );
              , "code-snippets");

              StackExchange.ready(function()
              var channelOptions =
              tags: "".split(" "),
              id: "1"
              ;
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function()
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled)
              StackExchange.using("snippets", function()
              createEditor();
              );

              else
              createEditor();

              );

              function createEditor()
              StackExchange.prepareEditor(
              heartbeatType: 'answer',
              convertImagesToLinks: true,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: 10,
              bindNavPrevention: true,
              postfix: "",
              imageUploader:
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              ,
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              );



              );













              draft saved

              draft discarded


















              StackExchange.ready(
              function ()
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53254502%2fcleanest-way-to-put-condition-inside-codeigniter-activerecord%23new-answer', 'question_page');

              );

              Post as a guest















              Required, but never shown

























              2 Answers
              2






              active

              oldest

              votes








              2 Answers
              2






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes








              up vote
              0
              down vote













              public function getData($numb, $period, $status)
              $this->db->select("COUNT(*) AS jml")
              ->from()
              ->where_not_in()
              ->where_in()
              ->group_by("");
              if($status !== 'all')
              $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

              return $query = $this->db->get();







              share|improve this answer
























                up vote
                0
                down vote













                public function getData($numb, $period, $status)
                $this->db->select("COUNT(*) AS jml")
                ->from()
                ->where_not_in()
                ->where_in()
                ->group_by("");
                if($status !== 'all')
                $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

                return $query = $this->db->get();







                share|improve this answer






















                  up vote
                  0
                  down vote










                  up vote
                  0
                  down vote









                  public function getData($numb, $period, $status)
                  $this->db->select("COUNT(*) AS jml")
                  ->from()
                  ->where_not_in()
                  ->where_in()
                  ->group_by("");
                  if($status !== 'all')
                  $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

                  return $query = $this->db->get();







                  share|improve this answer












                  public function getData($numb, $period, $status)
                  $this->db->select("COUNT(*) AS jml")
                  ->from()
                  ->where_not_in()
                  ->where_in()
                  ->group_by("");
                  if($status !== 'all')
                  $this->db->where("LAYANAN.TGL_LAYANAN BETWEEN DATEADD(" . $period ."," . $numb .", GETDATE()) AND GETDATE()");

                  return $query = $this->db->get();








                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered Nov 12 at 3:55









                  SANDEEP S S

                  668




                  668






















                      up vote
                      0
                      down vote













                      Utilize double-quote for the overall string and single quotes around the arguments to DATEADD



                      $this->db->where("LAYANAN.TGL_LAYANAN 
                      BETWEEN DATEADD(`$period`,`$numb`, GETDATE()) AND GETDATE()");





                      share|improve this answer
























                        up vote
                        0
                        down vote













                        Utilize double-quote for the overall string and single quotes around the arguments to DATEADD



                        $this->db->where("LAYANAN.TGL_LAYANAN 
                        BETWEEN DATEADD(`$period`,`$numb`, GETDATE()) AND GETDATE()");





                        share|improve this answer






















                          up vote
                          0
                          down vote










                          up vote
                          0
                          down vote









                          Utilize double-quote for the overall string and single quotes around the arguments to DATEADD



                          $this->db->where("LAYANAN.TGL_LAYANAN 
                          BETWEEN DATEADD(`$period`,`$numb`, GETDATE()) AND GETDATE()");





                          share|improve this answer












                          Utilize double-quote for the overall string and single quotes around the arguments to DATEADD



                          $this->db->where("LAYANAN.TGL_LAYANAN 
                          BETWEEN DATEADD(`$period`,`$numb`, GETDATE()) AND GETDATE()");






                          share|improve this answer












                          share|improve this answer



                          share|improve this answer










                          answered Nov 12 at 4:06









                          DFriend

                          6,6491520




                          6,6491520



























                              draft saved

                              draft discarded
















































                              Thanks for contributing an answer to Stack Overflow!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid


                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.

                              To learn more, see our tips on writing great answers.





                              Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                              Please pay close attention to the following guidance:


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid


                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.

                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function ()
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53254502%2fcleanest-way-to-put-condition-inside-codeigniter-activerecord%23new-answer', 'question_page');

                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              Popular posts from this blog

                              Top Tejano songwriter Luis Silva dead of heart attack at 64

                              ReactJS Fetched API data displays live - need Data displayed static

                              政党