Correctly implement hashcode for matrix java
I have a Java class containing a 2D int array. I want to implement the hashCode() method so that different objects can be compared using their attributes and not reference. This is what I tried:
public int hashCode()
int hash = 0;
for(int i=0; i<getMatrix().length; i++)
hash =+ Arrays.hashCode(getMatrix()[i]);
return hash;
I also tried using deepHashCode() but didn't work. My problem is that when the get() method of a HashMap object is used, even though both the object have the same matrix, the get() method does not work properly.
EDIT:
Implementation of equals method
public boolean equals(Object o)
boolean sameBoard = false;
if(o != null && o instanceof Node)
Node node = (Node) o;
int board1 = this.getMatrix();
int board2 = node.getMatrix();
return Arrays.deepEquals(board1, board2);
return sameBoard;
java
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
|
show 1 more comment
I have a Java class containing a 2D int array. I want to implement the hashCode() method so that different objects can be compared using their attributes and not reference. This is what I tried:
public int hashCode()
int hash = 0;
for(int i=0; i<getMatrix().length; i++)
hash =+ Arrays.hashCode(getMatrix()[i]);
return hash;
I also tried using deepHashCode() but didn't work. My problem is that when the get() method of a HashMap object is used, even though both the object have the same matrix, the get() method does not work properly.
EDIT:
Implementation of equals method
public boolean equals(Object o)
boolean sameBoard = false;
if(o != null && o instanceof Node)
Node node = (Node) o;
int board1 = this.getMatrix();
int board2 = node.getMatrix();
return Arrays.deepEquals(board1, board2);
return sameBoard;
java
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
1
Did you also implementequals? If so, can you also post your implementation of it as an edit to your post?
– Andrey Akhmetov
Nov 12 at 20:47
@AndreyAkhmetov i posted it
– Sebastian Ampuero Morisaki
Nov 12 at 20:51
2
Post a complete minimal example reproducing the problem. We must be able to copy and paste your code in our IDE, compile and run it. My guess is that you modify the matrix after you've stored it in the map.
– JB Nizet
Nov 12 at 20:54
3
Do you mean+=, rather than=+? As it stands, your hash will simply be the hash of the last... row?
– Andy Turner
Nov 12 at 21:00
1
Good catch @AndyTurner! That said, that should still work: it's just a weaker hashCode.
– JB Nizet
Nov 12 at 21:03
|
show 1 more comment
I have a Java class containing a 2D int array. I want to implement the hashCode() method so that different objects can be compared using their attributes and not reference. This is what I tried:
public int hashCode()
int hash = 0;
for(int i=0; i<getMatrix().length; i++)
hash =+ Arrays.hashCode(getMatrix()[i]);
return hash;
I also tried using deepHashCode() but didn't work. My problem is that when the get() method of a HashMap object is used, even though both the object have the same matrix, the get() method does not work properly.
EDIT:
Implementation of equals method
public boolean equals(Object o)
boolean sameBoard = false;
if(o != null && o instanceof Node)
Node node = (Node) o;
int board1 = this.getMatrix();
int board2 = node.getMatrix();
return Arrays.deepEquals(board1, board2);
return sameBoard;
java
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
I have a Java class containing a 2D int array. I want to implement the hashCode() method so that different objects can be compared using their attributes and not reference. This is what I tried:
public int hashCode()
int hash = 0;
for(int i=0; i<getMatrix().length; i++)
hash =+ Arrays.hashCode(getMatrix()[i]);
return hash;
I also tried using deepHashCode() but didn't work. My problem is that when the get() method of a HashMap object is used, even though both the object have the same matrix, the get() method does not work properly.
EDIT:
Implementation of equals method
public boolean equals(Object o)
boolean sameBoard = false;
if(o != null && o instanceof Node)
Node node = (Node) o;
int board1 = this.getMatrix();
int board2 = node.getMatrix();
return Arrays.deepEquals(board1, board2);
return sameBoard;
java
java
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
edited Nov 12 at 20:51
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
asked Nov 12 at 20:45
Sebastian Ampuero Morisaki
929
929
1
Did you also implementequals? If so, can you also post your implementation of it as an edit to your post?
– Andrey Akhmetov
Nov 12 at 20:47
@AndreyAkhmetov i posted it
– Sebastian Ampuero Morisaki
Nov 12 at 20:51
2
Post a complete minimal example reproducing the problem. We must be able to copy and paste your code in our IDE, compile and run it. My guess is that you modify the matrix after you've stored it in the map.
– JB Nizet
Nov 12 at 20:54
3
Do you mean+=, rather than=+? As it stands, your hash will simply be the hash of the last... row?
– Andy Turner
Nov 12 at 21:00
1
Good catch @AndyTurner! That said, that should still work: it's just a weaker hashCode.
– JB Nizet
Nov 12 at 21:03
|
show 1 more comment
1
Did you also implementequals? If so, can you also post your implementation of it as an edit to your post?
– Andrey Akhmetov
Nov 12 at 20:47
@AndreyAkhmetov i posted it
– Sebastian Ampuero Morisaki
Nov 12 at 20:51
2
Post a complete minimal example reproducing the problem. We must be able to copy and paste your code in our IDE, compile and run it. My guess is that you modify the matrix after you've stored it in the map.
– JB Nizet
Nov 12 at 20:54
3
Do you mean+=, rather than=+? As it stands, your hash will simply be the hash of the last... row?
– Andy Turner
Nov 12 at 21:00
1
Good catch @AndyTurner! That said, that should still work: it's just a weaker hashCode.
– JB Nizet
Nov 12 at 21:03
1
1
Did you also implement
equals? If so, can you also post your implementation of it as an edit to your post?– Andrey Akhmetov
Nov 12 at 20:47
Did you also implement
equals? If so, can you also post your implementation of it as an edit to your post?– Andrey Akhmetov
Nov 12 at 20:47
@AndreyAkhmetov i posted it
– Sebastian Ampuero Morisaki
Nov 12 at 20:51
@AndreyAkhmetov i posted it
– Sebastian Ampuero Morisaki
Nov 12 at 20:51
2
2
Post a complete minimal example reproducing the problem. We must be able to copy and paste your code in our IDE, compile and run it. My guess is that you modify the matrix after you've stored it in the map.
– JB Nizet
Nov 12 at 20:54
Post a complete minimal example reproducing the problem. We must be able to copy and paste your code in our IDE, compile and run it. My guess is that you modify the matrix after you've stored it in the map.
– JB Nizet
Nov 12 at 20:54
3
3
Do you mean
+=, rather than =+? As it stands, your hash will simply be the hash of the last... row?– Andy Turner
Nov 12 at 21:00
Do you mean
+=, rather than =+? As it stands, your hash will simply be the hash of the last... row?– Andy Turner
Nov 12 at 21:00
1
1
Good catch @AndyTurner! That said, that should still work: it's just a weaker hashCode.
– JB Nizet
Nov 12 at 21:03
Good catch @AndyTurner! That said, that should still work: it's just a weaker hashCode.
– JB Nizet
Nov 12 at 21:03
|
show 1 more comment
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269831%2fcorrectly-implement-hashcode-for-matrix-java%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269831%2fcorrectly-implement-hashcode-for-matrix-java%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Did you also implement
equals? If so, can you also post your implementation of it as an edit to your post?– Andrey Akhmetov
Nov 12 at 20:47
@AndreyAkhmetov i posted it
– Sebastian Ampuero Morisaki
Nov 12 at 20:51
2
Post a complete minimal example reproducing the problem. We must be able to copy and paste your code in our IDE, compile and run it. My guess is that you modify the matrix after you've stored it in the map.
– JB Nizet
Nov 12 at 20:54
3
Do you mean
+=, rather than=+? As it stands, your hash will simply be the hash of the last... row?– Andy Turner
Nov 12 at 21:00
1
Good catch @AndyTurner! That said, that should still work: it's just a weaker hashCode.
– JB Nizet
Nov 12 at 21:03