Myujth

I am trying to change values of my class from an override method as shown below:

 public class QuestionAnalyser extends AppCompatActivity 
 String question;
 String entityIdentified;
 static boolean identified = false;
 DatabaseReference entityRef;
 TranslatorServant t = new TranslatorServant();

 @Override
 protected void onCreate(Bundle savedInstanceState) 
 super.onCreate(savedInstanceState);
 setContentView(R.layout.activity_interface);

 

 public void analyse(String userQues) 
 if (!(Interface.deviceLang.equals("en"))) 
 TranslatorServant t = new TranslatorServant();
 question = t.translateText(userQues);
 else 
 question = userQues;
 
 question = question.replaceAll("\pPunct

 private void getEntity(final String words) 
 entityRef = FirebaseDatabase.getInstance().getReference().child("IRAdata").child("Entities");
 entityRef.addValueEventListener(new ValueEventListener() 
 @Override
 public void onDataChange(@NonNull DataSnapshot dataSnapshot) 
 for (DataSnapshot entity : dataSnapshot.getChildren()) 
 String synonyms = entity.child("syn").getValue().toString().split(",");
 for (String syn : synonyms) 
 for (String word : words) question.equalsIgnoreCase(syn)) 
 mimicOtherMessage("found");
 entityIdentified = entity.getKey();
 identified = true;
 
 
 
 
 
 @Override
 public void onCancelled(@NonNull DatabaseError databaseError) 
 Toast.makeText(getApplicationContext(), databaseError.getMessage(), Toast.LENGTH_SHORT).show();

 
 );
 if (identified == false) 
 for (String yes : YesNo.yes) 
 for (String w : words) 
 for (String no : YesNo.no) 
 for (String w : words) 
 if (w.equalsIgnoreCase(no) 
 

 
 
 return;
 
 

From the analyse() method i am calling the getEntity() method, the override method is working fine and is changing the value of identified and entityIdentified accordingly but, when the method is completed the updates are not reflected on the variables.

I have tried to debug, i could see the values changing in the override method, but when i check the values of the variables after the override method, i could only get the initial values. Somebody can help me on this please?

I have tried implementing threads as well, to make sure the method getEntity() gets completed before returning to the main, but the problem persists.

The code you have written is not very detailed to me, but your logic could be restructured in a way, similar to what I have done below:

public class QuestionAnalyser extends AppCompatActivity 
 String question;
 String entityIdentified;
 static boolean identified = false;
 DatabaseReference entityRef;
 TranslatorServant t = new TranslatorServant();

 @Override
 protected void onCreate(Bundle savedInstanceState) 
 super.onCreate(savedInstanceState);
 setContentView(R.layout.activity_interface);

 

 public void analyse(String userQues) \d", "");
 final String words = question.split(" ");
 getEntity(words);
 // remove any logic that depends on the return of getEntity(words) from here
 // it is best if the logic is called from within the Firebase call
 

 private void getEntity(final String words) 
 entityRef = FirebaseDatabase.getInstance().getReference().child("IRAdata").child("Entities");
 entityRef.addValueEventListener(new ValueEventListener() 
 @Override
 public void onDataChange(@NonNull DataSnapshot dataSnapshot) 
 for (DataSnapshot entity : dataSnapshot.getChildren()) 
 String synonyms = entity.child("syn").getValue().toString().split(",");
 for (String syn : synonyms) 
 for (String word : words) 
 if (word.equalsIgnoreCase(syn) 
 
 
 

 @Override
 public void onCancelled(@NonNull DatabaseError databaseError) 
 Toast.makeText(getApplicationContext(), databaseError.getMessage(), Toast.LENGTH_SHORT).show();

 
 );
 // the logic here will have to also be moved into the Firebase call
 
 

Note that, the parts that required the check on identified have all been moved to the onDataChanged method.

Please move your code written after getEntity()
Inside onDataChange() method. When onDataChange() completes it will execute added code. You will get latest values in variables.