Improving QGIS source code efficiency?









up vote
4
down vote

favorite












I have noticed in the QGIS source code that the map layers gets added in two
different places, in the Canvas and in the registry as follow:



 QgsMapLayerRegistry::instance()->addMapLayers(theMapLayers, TRUE);

//! Create the Map Canvas
m_pMapCanvas = new QgsMapCanvas(0, 0);
// Set the Map Canvas Layer Set
m_pMapCanvas->setLayerSet(myRList);


It seems like two separate copies of the map layers is being added to two different places, is there is away to make this more efficient?










share|improve this question



























    up vote
    4
    down vote

    favorite












    I have noticed in the QGIS source code that the map layers gets added in two
    different places, in the Canvas and in the registry as follow:



     QgsMapLayerRegistry::instance()->addMapLayers(theMapLayers, TRUE);

    //! Create the Map Canvas
    m_pMapCanvas = new QgsMapCanvas(0, 0);
    // Set the Map Canvas Layer Set
    m_pMapCanvas->setLayerSet(myRList);


    It seems like two separate copies of the map layers is being added to two different places, is there is away to make this more efficient?










    share|improve this question

























      up vote
      4
      down vote

      favorite









      up vote
      4
      down vote

      favorite











      I have noticed in the QGIS source code that the map layers gets added in two
      different places, in the Canvas and in the registry as follow:



       QgsMapLayerRegistry::instance()->addMapLayers(theMapLayers, TRUE);

      //! Create the Map Canvas
      m_pMapCanvas = new QgsMapCanvas(0, 0);
      // Set the Map Canvas Layer Set
      m_pMapCanvas->setLayerSet(myRList);


      It seems like two separate copies of the map layers is being added to two different places, is there is away to make this more efficient?










      share|improve this question















      I have noticed in the QGIS source code that the map layers gets added in two
      different places, in the Canvas and in the registry as follow:



       QgsMapLayerRegistry::instance()->addMapLayers(theMapLayers, TRUE);

      //! Create the Map Canvas
      m_pMapCanvas = new QgsMapCanvas(0, 0);
      // Set the Map Canvas Layer Set
      m_pMapCanvas->setLayerSet(myRList);


      It seems like two separate copies of the map layers is being added to two different places, is there is away to make this more efficient?







      qgis c++






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 11 at 16:37









      Vince

      14.3k32646




      14.3k32646










      asked Nov 11 at 5:39









      user9995

      473




      473




















          1 Answer
          1






          active

          oldest

          votes

















          up vote
          6
          down vote













          There's no inefficiency here. They are only c++ pointers to the same layer instance -- it's not two instances in separate memory of the same map layer.






          share|improve this answer




















            Your Answer








            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "79"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fgis.stackexchange.com%2fquestions%2f302168%2fimproving-qgis-source-code-efficiency%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            6
            down vote













            There's no inefficiency here. They are only c++ pointers to the same layer instance -- it's not two instances in separate memory of the same map layer.






            share|improve this answer
























              up vote
              6
              down vote













              There's no inefficiency here. They are only c++ pointers to the same layer instance -- it's not two instances in separate memory of the same map layer.






              share|improve this answer






















                up vote
                6
                down vote










                up vote
                6
                down vote









                There's no inefficiency here. They are only c++ pointers to the same layer instance -- it's not two instances in separate memory of the same map layer.






                share|improve this answer












                There's no inefficiency here. They are only c++ pointers to the same layer instance -- it's not two instances in separate memory of the same map layer.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 11 at 8:56









                ndawson

                17.6k22640




                17.6k22640



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Geographic Information Systems Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fgis.stackexchange.com%2fquestions%2f302168%2fimproving-qgis-source-code-efficiency%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Top Tejano songwriter Luis Silva dead of heart attack at 64

                    ReactJS Fetched API data displays live - need Data displayed static

                    Evgeni Malkin