correct way to fire out a fail result in page reponse event listener in codeceptJS










0















I wrote a helper methods to add a network response listener over Puppeteer page instance. the code looks like this



let Helper = codecept_helper;

class CheckHelper extends Helper
async listenRequest(listener)

const helper = this.helpers['Puppeteer'];
await helper.page.setRequestInterception(true);
helper.page.on("request",listener);
return helper._waitForAction();

async listenResponse(listener)

const helper = this.helpers['Puppeteer'];
helper.page.on("response",listener);
return helper._waitForAction();



module.exports = CheckHelper;


then in the test script



 let self=this;
I.listenResponse((response)=>
if(response.url().match(/github.*.js/) && response.headers()['content-length']>1000)
//codeceptjs.event.emit(codeceptjs.event.test.failed, self, 'js file is too big!');
//codeceptjs.recorder.throw('js file is too big!')
//codeceptjs.recorder.stop();
//throw new Error('js file is too big!')

)
I.amOnPage("https://www.github.com");


i first add response listener, then i goto "github", when some js file size is too big,i will throw out an error,in order too check content size is correctly.



however, even i throw error out (like the comments codes did), the main test flow just not stop, how do i do is the right way?










share|improve this question




























    0















    I wrote a helper methods to add a network response listener over Puppeteer page instance. the code looks like this



    let Helper = codecept_helper;

    class CheckHelper extends Helper
    async listenRequest(listener)

    const helper = this.helpers['Puppeteer'];
    await helper.page.setRequestInterception(true);
    helper.page.on("request",listener);
    return helper._waitForAction();

    async listenResponse(listener)

    const helper = this.helpers['Puppeteer'];
    helper.page.on("response",listener);
    return helper._waitForAction();



    module.exports = CheckHelper;


    then in the test script



     let self=this;
    I.listenResponse((response)=>
    if(response.url().match(/github.*.js/) && response.headers()['content-length']>1000)
    //codeceptjs.event.emit(codeceptjs.event.test.failed, self, 'js file is too big!');
    //codeceptjs.recorder.throw('js file is too big!')
    //codeceptjs.recorder.stop();
    //throw new Error('js file is too big!')

    )
    I.amOnPage("https://www.github.com");


    i first add response listener, then i goto "github", when some js file size is too big,i will throw out an error,in order too check content size is correctly.



    however, even i throw error out (like the comments codes did), the main test flow just not stop, how do i do is the right way?










    share|improve this question


























      0












      0








      0








      I wrote a helper methods to add a network response listener over Puppeteer page instance. the code looks like this



      let Helper = codecept_helper;

      class CheckHelper extends Helper
      async listenRequest(listener)

      const helper = this.helpers['Puppeteer'];
      await helper.page.setRequestInterception(true);
      helper.page.on("request",listener);
      return helper._waitForAction();

      async listenResponse(listener)

      const helper = this.helpers['Puppeteer'];
      helper.page.on("response",listener);
      return helper._waitForAction();



      module.exports = CheckHelper;


      then in the test script



       let self=this;
      I.listenResponse((response)=>
      if(response.url().match(/github.*.js/) && response.headers()['content-length']>1000)
      //codeceptjs.event.emit(codeceptjs.event.test.failed, self, 'js file is too big!');
      //codeceptjs.recorder.throw('js file is too big!')
      //codeceptjs.recorder.stop();
      //throw new Error('js file is too big!')

      )
      I.amOnPage("https://www.github.com");


      i first add response listener, then i goto "github", when some js file size is too big,i will throw out an error,in order too check content size is correctly.



      however, even i throw error out (like the comments codes did), the main test flow just not stop, how do i do is the right way?










      share|improve this question
















      I wrote a helper methods to add a network response listener over Puppeteer page instance. the code looks like this



      let Helper = codecept_helper;

      class CheckHelper extends Helper
      async listenRequest(listener)

      const helper = this.helpers['Puppeteer'];
      await helper.page.setRequestInterception(true);
      helper.page.on("request",listener);
      return helper._waitForAction();

      async listenResponse(listener)

      const helper = this.helpers['Puppeteer'];
      helper.page.on("response",listener);
      return helper._waitForAction();



      module.exports = CheckHelper;


      then in the test script



       let self=this;
      I.listenResponse((response)=>
      if(response.url().match(/github.*.js/) && response.headers()['content-length']>1000)
      //codeceptjs.event.emit(codeceptjs.event.test.failed, self, 'js file is too big!');
      //codeceptjs.recorder.throw('js file is too big!')
      //codeceptjs.recorder.stop();
      //throw new Error('js file is too big!')

      )
      I.amOnPage("https://www.github.com");


      i first add response listener, then i goto "github", when some js file size is too big,i will throw out an error,in order too check content size is correctly.



      however, even i throw error out (like the comments codes did), the main test flow just not stop, how do i do is the right way?







      automated-tests puppeteer codeceptjs






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 16 '18 at 2:27







      Kent Wood

















      asked Nov 16 '18 at 2:13









      Kent WoodKent Wood

      3311313




      3311313






















          1 Answer
          1






          active

          oldest

          votes


















          0














          well,i found a solution later



          i recorded all the page response into a custom object in the page instance.
          later i wrote a help methods to check whole records.



          //in helper.js
          startRecordResponse()
          const helper = this.helpers['Puppeteer'];
          helper.page.on("response", (res) => );
          return helper._waitForAction();


          checkFileIsTooBig(filter, sizeLimit)
          const helper = this.helpers['Puppeteer'];
          //use the data recorded in savedResponse object
          Object.keys(helper.page.savedResponse).forEach((url) => (typeof filter == "string" && url.indexOf(filter) != -1)) && res.headers()['content-length'] > sizeLimit)
          throw new Error(`file $url is too big,$res.headers()['content-length'] > $sizeLimit`)

          )
          return helper._waitForAction();



          then in test file



          Before((I) => 
          I.startRecordResponse();
          I.amOnPage("https://www.github.com");
          );

          Scenario('github_test', (I) =>
          //check a js file contain github is less than 100 bytes
          I.checkFileIsTooBig(/github.*.js/,100);

          );





          share|improve this answer






















            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "1"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53330497%2fcorrect-way-to-fire-out-a-fail-result-in-page-reponse-event-listener-in-codecept%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0














            well,i found a solution later



            i recorded all the page response into a custom object in the page instance.
            later i wrote a help methods to check whole records.



            //in helper.js
            startRecordResponse()
            const helper = this.helpers['Puppeteer'];
            helper.page.on("response", (res) => );
            return helper._waitForAction();


            checkFileIsTooBig(filter, sizeLimit)
            const helper = this.helpers['Puppeteer'];
            //use the data recorded in savedResponse object
            Object.keys(helper.page.savedResponse).forEach((url) => (typeof filter == "string" && url.indexOf(filter) != -1)) && res.headers()['content-length'] > sizeLimit)
            throw new Error(`file $url is too big,$res.headers()['content-length'] > $sizeLimit`)

            )
            return helper._waitForAction();



            then in test file



            Before((I) => 
            I.startRecordResponse();
            I.amOnPage("https://www.github.com");
            );

            Scenario('github_test', (I) =>
            //check a js file contain github is less than 100 bytes
            I.checkFileIsTooBig(/github.*.js/,100);

            );





            share|improve this answer



























              0














              well,i found a solution later



              i recorded all the page response into a custom object in the page instance.
              later i wrote a help methods to check whole records.



              //in helper.js
              startRecordResponse()
              const helper = this.helpers['Puppeteer'];
              helper.page.on("response", (res) => );
              return helper._waitForAction();


              checkFileIsTooBig(filter, sizeLimit)
              const helper = this.helpers['Puppeteer'];
              //use the data recorded in savedResponse object
              Object.keys(helper.page.savedResponse).forEach((url) => (typeof filter == "string" && url.indexOf(filter) != -1)) && res.headers()['content-length'] > sizeLimit)
              throw new Error(`file $url is too big,$res.headers()['content-length'] > $sizeLimit`)

              )
              return helper._waitForAction();



              then in test file



              Before((I) => 
              I.startRecordResponse();
              I.amOnPage("https://www.github.com");
              );

              Scenario('github_test', (I) =>
              //check a js file contain github is less than 100 bytes
              I.checkFileIsTooBig(/github.*.js/,100);

              );





              share|improve this answer

























                0












                0








                0







                well,i found a solution later



                i recorded all the page response into a custom object in the page instance.
                later i wrote a help methods to check whole records.



                //in helper.js
                startRecordResponse()
                const helper = this.helpers['Puppeteer'];
                helper.page.on("response", (res) => );
                return helper._waitForAction();


                checkFileIsTooBig(filter, sizeLimit)
                const helper = this.helpers['Puppeteer'];
                //use the data recorded in savedResponse object
                Object.keys(helper.page.savedResponse).forEach((url) => (typeof filter == "string" && url.indexOf(filter) != -1)) && res.headers()['content-length'] > sizeLimit)
                throw new Error(`file $url is too big,$res.headers()['content-length'] > $sizeLimit`)

                )
                return helper._waitForAction();



                then in test file



                Before((I) => 
                I.startRecordResponse();
                I.amOnPage("https://www.github.com");
                );

                Scenario('github_test', (I) =>
                //check a js file contain github is less than 100 bytes
                I.checkFileIsTooBig(/github.*.js/,100);

                );





                share|improve this answer













                well,i found a solution later



                i recorded all the page response into a custom object in the page instance.
                later i wrote a help methods to check whole records.



                //in helper.js
                startRecordResponse()
                const helper = this.helpers['Puppeteer'];
                helper.page.on("response", (res) => );
                return helper._waitForAction();


                checkFileIsTooBig(filter, sizeLimit)
                const helper = this.helpers['Puppeteer'];
                //use the data recorded in savedResponse object
                Object.keys(helper.page.savedResponse).forEach((url) => (typeof filter == "string" && url.indexOf(filter) != -1)) && res.headers()['content-length'] > sizeLimit)
                throw new Error(`file $url is too big,$res.headers()['content-length'] > $sizeLimit`)

                )
                return helper._waitForAction();



                then in test file



                Before((I) => 
                I.startRecordResponse();
                I.amOnPage("https://www.github.com");
                );

                Scenario('github_test', (I) =>
                //check a js file contain github is less than 100 bytes
                I.checkFileIsTooBig(/github.*.js/,100);

                );






                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 16 '18 at 8:28









                Kent WoodKent Wood

                3311313




                3311313





























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53330497%2fcorrect-way-to-fire-out-a-fail-result-in-page-reponse-event-listener-in-codecept%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Top Tejano songwriter Luis Silva dead of heart attack at 64

                    政党

                    天津地下鉄3号線