Myujth

I have a question about finding the selected Item of my CollectionViewCells. I want to bring the Data to another ViewController and then edit and save it to the selected Item of my Cells? The Problem is that there my current Item is alway 0 and so my first CollectionCell? I use for testing a ItemList.txt file.

One of the cells:

Here is my EditViewController:

class EditViewController: UIViewController 
 var itemList = ListItem.load() 
 didSet 
 ListItem.save(itemList)
 
 

 @IBOutlet weak var editTextField: UITextField!
 @IBOutlet weak var editView: UIView!

 //var currentItem = 0
 var currentText = ""
 var currentItem = 0

 override func viewDidLoad() 
 super.viewDidLoad()

 editTextField.text = itemList[currentItem]

 editView.clipsToBounds = true
 editView.layer.borderColor = UIColor.black.cgColor
 editView.layer.cornerRadius = 25
 

 @IBAction func saveButton(_ sender: Any) 
 self.dismiss(animated: true, completion: nil)
 editTextField.resignFirstResponder()
 

 @IBAction func cancelButton(_ sender: Any) 
 self.dismiss(animated: true, completion: nil)
 editTextField.resignFirstResponder()
 

 override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) 
 self.editView.endEditing(true)
 

Here is my CollectionViewCell:

class CollectionViewCell: UICollectionViewCell 
 var btnTapAction : (()->())?

 @IBOutlet weak var listLabel: UILabel!
 @IBOutlet weak var editButton: UIButton!

 required init?(coder aDecoder: NSCoder) 
 super.init(coder: aDecoder)

 self.layer.cornerRadius = self.frame.size.width * 0.1
 self.layer.borderWidth = 0
 self.layer.borderColor = UIColor(red: 0.5, green: 0.47, blue: 0.25, alpha: 1.0).cgColor
 

 @IBAction func editButtonTapped(_ sender: UIButton) 
 print("Tapped!")

 btnTapAction?()
 

Here my cellForItemAt in the Main ViewController:

 func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell 
 let cell : CollectionViewCell = collectionView.dequeueReusableCell(withReuseIdentifier: "CollectionViewCell", for: indexPath) as! CollectionViewCell
 cell.listLabel.text = itemList[indexPath.row]

 cell.editButton.addTarget(self, action: #selector(editButtonTapped), for: UIControl.Event.touchUpInside)
 cell.editButton.tag = indexPath.item
 cell.editButton.isUserInteractionEnabled = true

 cell.btnTapAction = () in
 print("Edit tapped in cell", indexPath.item)
 // start your edit process here...
 let storyboard = UIStoryboard(name: "Main", bundle: nil)
 let viewController = storyboard.instantiateViewController(withIdentifier: "edit") as! EditViewController
 viewController.currentItem = indexPath.item
 print("(viewController.currentItem)")
 

 return cell
 

Here my ViewCollectionViewCell:

class CollectionViewCell: UICollectionViewCell 
 
 var btnTapAction : (()->())?
 
 @IBOutlet weak var listLabel: UILabel!
 @IBOutlet weak var editButton: UIButton!
 
 required init?(coder aDecoder: NSCoder) 
 super.init(coder: aDecoder)
 
 self.layer.cornerRadius = self.frame.size.width * 0.1
 self.layer.borderWidth = 0
 self.layer.borderColor = UIColor(red: 0.5, green: 0.47, blue: 0.25, alpha: 1.0).cgColor
 
 
 @IBAction func editButtonTapped(_ sender: UIButton) 
 print("Tapped!")
 
 btnTapAction?()
 
 

Maybe there is an answer for that, but I didn't find it.

Your approach is not-quite-right.

In your .btnTapAction closure, you create a new instance of EditViewController. However, as soon as that closure exits, that instance no longer exists.

 cell.btnTapAction = () in
 // you tapped the button
 // this line prints the indexPath.item to the console
 print("Edit tapped in cell", indexPath.item)

 let storyboard = UIStoryboard(name: "Main", bundle: nil)

 // here, you create an instance of EditViewController
 let viewController = storyboard.instantiateViewController(withIdentifier: "edit") as! EditViewController

 // here, you set .currentItem in the instance of EditViewController
 viewController.currentItem = indexPath.item

 // you print that value to the console
 print("(viewController.currentItem)")

 // here, the closure exits, and
 // viewController no longer exists!
 

At the same time you are running that code, your Segue is creating its own instance of EditViewController.

That's why .currentItem is always Zero.

Instead, you need to save the indexPath.item in a class-level variable, and then set .currentItem inside prepare(for segue: ...):

class YourCollectionViewController: UICollectionViewController 

 var selectedItem = 0

 override func prepare(for segue: UIStoryboardSegue, sender: Any?) 

 if let newEditVC = segue.destination as? EditViewController 
 newEditVC.currentItem = self.selectedItem
 

 

 func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell 
 let cell : CollectionViewCell = collectionView.dequeueReusableCell(withReuseIdentifier: "CollectionViewCell", for: indexPath) as! CollectionViewCell
 cell.listLabel.text = itemList[indexPath.row]

 cell.editButton.addTarget(self, action: #selector(editButtonTapped), for: UIControl.Event.touchUpInside)
 cell.editButton.tag = indexPath.item
 cell.editButton.isUserInteractionEnabled = true


 cell.btnTapAction = () in
 // you tapped the button
 // this line prints the indexPath.item to the console
 print("Edit tapped in cell", indexPath.item)

 // set your class-level variable
 // which will be used in prepare(for segue: ...)
 self.selectedItem = indexPath.item
 

 return cell

 

Or, another approach... Delete the Segue from Storyboard, and change your .btnTapAction to this:

 cell.btnTapAction = () in
 // you tapped the button
 // this line prints the indexPath.item to the console
 print("Edit tapped in cell", indexPath.item)

 let storyboard = UIStoryboard(name: "Main", bundle: nil)

 // here, you create an instance of EditViewController
 let viewController = storyboard.instantiateViewController(withIdentifier: "edit") as! EditViewController

 // here, you set .currentItem in the instance of EditViewController
 viewController.currentItem = indexPath.item

 // you print that value to the console
 print("(viewController.currentItem)")

 // present that instance of EditViewController
 self.present(viewController, animated: true, completion: nil)