Override html view in Rails break same js view?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty height:90px;width:728px;box-sizing:border-box;
I use Redmine 3.3.3 and I made a plugin Gem for it.
Recently, I have found something that seems to be a Rails (4.2) bug, but maybe I don't do the right things ^^
In Redmine, there is 2 formats defined for view/issues/edit :
- REDMINE/app/view/issues/edit.html.erb
- REDMINE/app/view/issues/edit.js.erb
The edit.js.erb is used for change some fields in ajax when user update some fields (statut field for example)
In my plugin Gem, I override edit.html.erb :
- MYGEM/app/view/issues/edit.html.erb
With that override, Rails "break" edit.js.erb by resolving to MYGEM...edit.html.erb when js format is requested.
I can restore correct behavior by create an edit.js.erb in MYGEM with same content of Redmine one.
Do I really have to override js formats for all views files I override ?
In Rails, this behavior seems to be in actionview-4.2.7.1 :
- :html is the default fallback for :js format, so when :js is requested, we search for [:js, :html] formats (defined in lookup_context.rb : formats=() method)
- In path_set.rb, find(*args) return the first path for find_all
In path_set.rb, _find_all return the first templates returned by a resolver
=> We don't search in all path, the first responding resolver "hidding" the others, it's not really an "all" search
In template/resolver.rb, query method call extract_handler_and_format_and_variant
In this method, if we found a file with a valid format, we use it.
With existing edit.html.erb, we use it because :html format is allowed
=> We return in _find_all and we never search in REDMINE views
ruby-on-rails rubygems redmine
asked Nov 16 '18 at 11:04
FladnagFladnag
11
add a comment |
I use Redmine 3.3.3 and I made a plugin Gem for it.
Recently, I have found something that seems to be a Rails (4.2) bug, but maybe I don't do the right things ^^
In Redmine, there is 2 formats defined for view/issues/edit :
- REDMINE/app/view/issues/edit.html.erb
- REDMINE/app/view/issues/edit.js.erb
The edit.js.erb is used for change some fields in ajax when user update some fields (statut field for example)
In my plugin Gem, I override edit.html.erb :
- MYGEM/app/view/issues/edit.html.erb
With that override, Rails "break" edit.js.erb by resolving to MYGEM...edit.html.erb when js format is requested.
I can restore correct behavior by create an edit.js.erb in MYGEM with same content of Redmine one.
Do I really have to override js formats for all views files I override ?
In Rails, this behavior seems to be in actionview-4.2.7.1 :
- :html is the default fallback for :js format, so when :js is requested, we search for [:js, :html] formats (defined in lookup_context.rb : formats=() method)
- In path_set.rb, find(*args) return the first path for find_all
In path_set.rb, _find_all return the first templates returned by a resolver
=> We don't search in all path, the first responding resolver "hidding" the others, it's not really an "all" search
In template/resolver.rb, query method call extract_handler_and_format_and_variant
In this method, if we found a file with a valid format, we use it.
With existing edit.html.erb, we use it because :html format is allowed
=> We return in _find_all and we never search in REDMINE views
ruby-on-rails rubygems redmine
asked Nov 16 '18 at 11:04
FladnagFladnag
11
seems same issue : stackoverflow.com/questions/9030826/…
– Fladnag
Nov 16 '18 at 14:11
add a comment |
I use Redmine 3.3.3 and I made a plugin Gem for it.
Recently, I have found something that seems to be a Rails (4.2) bug, but maybe I don't do the right things ^^
In Redmine, there is 2 formats defined for view/issues/edit :
- REDMINE/app/view/issues/edit.html.erb
- REDMINE/app/view/issues/edit.js.erb
The edit.js.erb is used for change some fields in ajax when user update some fields (statut field for example)
In my plugin Gem, I override edit.html.erb :
- MYGEM/app/view/issues/edit.html.erb
With that override, Rails "break" edit.js.erb by resolving to MYGEM...edit.html.erb when js format is requested.
I can restore correct behavior by create an edit.js.erb in MYGEM with same content of Redmine one.
Do I really have to override js formats for all views files I override ?
In Rails, this behavior seems to be in actionview-4.2.7.1 :
- :html is the default fallback for :js format, so when :js is requested, we search for [:js, :html] formats (defined in lookup_context.rb : formats=() method)
- In path_set.rb, find(*args) return the first path for find_all
In path_set.rb, _find_all return the first templates returned by a resolver
=> We don't search in all path, the first responding resolver "hidding" the others, it's not really an "all" search
In template/resolver.rb, query method call extract_handler_and_format_and_variant
In this method, if we found a file with a valid format, we use it.
With existing edit.html.erb, we use it because :html format is allowed
=> We return in _find_all and we never search in REDMINE views
ruby-on-rails rubygems redmine
asked Nov 16 '18 at 11:04
FladnagFladnag
11
I use Redmine 3.3.3 and I made a plugin Gem for it.
Recently, I have found something that seems to be a Rails (4.2) bug, but maybe I don't do the right things ^^
In Redmine, there is 2 formats defined for view/issues/edit :
- REDMINE/app/view/issues/edit.html.erb
- REDMINE/app/view/issues/edit.js.erb
The edit.js.erb is used for change some fields in ajax when user update some fields (statut field for example)
In my plugin Gem, I override edit.html.erb :
- MYGEM/app/view/issues/edit.html.erb
With that override, Rails "break" edit.js.erb by resolving to MYGEM...edit.html.erb when js format is requested.
I can restore correct behavior by create an edit.js.erb in MYGEM with same content of Redmine one.
Do I really have to override js formats for all views files I override ?
In Rails, this behavior seems to be in actionview-4.2.7.1 :
- :html is the default fallback for :js format, so when :js is requested, we search for [:js, :html] formats (defined in lookup_context.rb : formats=() method)
- In path_set.rb, find(*args) return the first path for find_all
In path_set.rb, _find_all return the first templates returned by a resolver
=> We don't search in all path, the first responding resolver "hidding" the others, it's not really an "all" search
In template/resolver.rb, query method call extract_handler_and_format_and_variant
In this method, if we found a file with a valid format, we use it.
With existing edit.html.erb, we use it because :html format is allowed
=> We return in _find_all and we never search in REDMINE views
ruby-on-rails rubygems redmine
ruby-on-rails rubygems redmine
asked Nov 16 '18 at 11:04
FladnagFladnag
11
asked Nov 16 '18 at 11:04
FladnagFladnag
11
edited Nov 16 '18 at 14:04
Fladnag
asked Nov 16 '18 at 11:04
FladnagFladnag
11
asked Nov 16 '18 at 11:04
FladnagFladnag
11
asked Nov 16 '18 at 11:04
FladnagFladnag
11
11
seems same issue : stackoverflow.com/questions/9030826/…
– Fladnag
Nov 16 '18 at 14:11
add a comment |
seems same issue : stackoverflow.com/questions/9030826/…
– Fladnag
Nov 16 '18 at 14:11
seems same issue : stackoverflow.com/questions/9030826/…
– Fladnag
Nov 16 '18 at 14:11
seems same issue : stackoverflow.com/questions/9030826/…
– Fladnag
Nov 16 '18 at 14:11
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53336596%2foverride-html-view-in-rails-break-same-js-view%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53336596%2foverride-html-view-in-rails-break-same-js-view%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
seems same issue : stackoverflow.com/questions/9030826/…
– Fladnag
Nov 16 '18 at 14:11