How can I use loops/recursion with promise-chains?









up vote
3
down vote

favorite












Imagine for example that you want to store paginated data from an API to a database.



let db;
let pageitems = 35
var offset = 0;

dbConnect //establish connection to database
.then( fetch(apiLink+?offset=2)
.then( res => res.json())
.then( res => {
var total = res.count
return collection.insertMany(res.data, ordered: false)
// If offset is less than total, I want to increase offset and go back to the fetch-event.
.catch( err =>
if(err.code !== 11000)log(err)
elselog(completed: err.result.nInserted, duplicates:
err.result.result.writeErrors.length);
)
.then(() =>
connection.close();
)









share|improve this question

















  • 1




    Your fetch only fetches pageitems (15) items? Is res.count the number of fetched records, or the total size of the data set at the backend?
    – trincot
    Nov 11 at 16:35







  • 2




    You can use async/await within a while loop. Or async/await is not an option here?
    – Sim Dim
    Nov 11 at 16:37






  • 2




    Warning: your code is calling fetch immediately, not when dbConnect resolves. You must put () => fetch(... there.
    – trincot
    Nov 11 at 16:40







  • 2




    Yes, recursion is the way to go. But just like in the non-promise case, for that you first need a function that you could call recursively.
    – Bergi
    Nov 11 at 16:43






  • 1




    @JonasWilms Sure, but it seems the OP tries to learn ES6 promise chaining first. My comment was just meant to be encouraging, that recursion is a correct approach, and the OP should try it. Later when adopting async/await you can of course use a loop.
    – Bergi
    Nov 11 at 17:00














up vote
3
down vote

favorite












Imagine for example that you want to store paginated data from an API to a database.



let db;
let pageitems = 35
var offset = 0;

dbConnect //establish connection to database
.then( fetch(apiLink+?offset=2)
.then( res => res.json())
.then( res => {
var total = res.count
return collection.insertMany(res.data, ordered: false)
// If offset is less than total, I want to increase offset and go back to the fetch-event.
.catch( err =>
if(err.code !== 11000)log(err)
elselog(completed: err.result.nInserted, duplicates:
err.result.result.writeErrors.length);
)
.then(() =>
connection.close();
)









share|improve this question

















  • 1




    Your fetch only fetches pageitems (15) items? Is res.count the number of fetched records, or the total size of the data set at the backend?
    – trincot
    Nov 11 at 16:35







  • 2




    You can use async/await within a while loop. Or async/await is not an option here?
    – Sim Dim
    Nov 11 at 16:37






  • 2




    Warning: your code is calling fetch immediately, not when dbConnect resolves. You must put () => fetch(... there.
    – trincot
    Nov 11 at 16:40







  • 2




    Yes, recursion is the way to go. But just like in the non-promise case, for that you first need a function that you could call recursively.
    – Bergi
    Nov 11 at 16:43






  • 1




    @JonasWilms Sure, but it seems the OP tries to learn ES6 promise chaining first. My comment was just meant to be encouraging, that recursion is a correct approach, and the OP should try it. Later when adopting async/await you can of course use a loop.
    – Bergi
    Nov 11 at 17:00












up vote
3
down vote

favorite









up vote
3
down vote

favorite











Imagine for example that you want to store paginated data from an API to a database.



let db;
let pageitems = 35
var offset = 0;

dbConnect //establish connection to database
.then( fetch(apiLink+?offset=2)
.then( res => res.json())
.then( res => {
var total = res.count
return collection.insertMany(res.data, ordered: false)
// If offset is less than total, I want to increase offset and go back to the fetch-event.
.catch( err =>
if(err.code !== 11000)log(err)
elselog(completed: err.result.nInserted, duplicates:
err.result.result.writeErrors.length);
)
.then(() =>
connection.close();
)









share|improve this question













Imagine for example that you want to store paginated data from an API to a database.



let db;
let pageitems = 35
var offset = 0;

dbConnect //establish connection to database
.then( fetch(apiLink+?offset=2)
.then( res => res.json())
.then( res => {
var total = res.count
return collection.insertMany(res.data, ordered: false)
// If offset is less than total, I want to increase offset and go back to the fetch-event.
.catch( err =>
if(err.code !== 11000)log(err)
elselog(completed: err.result.nInserted, duplicates:
err.result.result.writeErrors.length);
)
.then(() =>
connection.close();
)






javascript node.js ecmascript-6






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 11 at 16:31









Himmators

5,5012684171




5,5012684171







  • 1




    Your fetch only fetches pageitems (15) items? Is res.count the number of fetched records, or the total size of the data set at the backend?
    – trincot
    Nov 11 at 16:35







  • 2




    You can use async/await within a while loop. Or async/await is not an option here?
    – Sim Dim
    Nov 11 at 16:37






  • 2




    Warning: your code is calling fetch immediately, not when dbConnect resolves. You must put () => fetch(... there.
    – trincot
    Nov 11 at 16:40







  • 2




    Yes, recursion is the way to go. But just like in the non-promise case, for that you first need a function that you could call recursively.
    – Bergi
    Nov 11 at 16:43






  • 1




    @JonasWilms Sure, but it seems the OP tries to learn ES6 promise chaining first. My comment was just meant to be encouraging, that recursion is a correct approach, and the OP should try it. Later when adopting async/await you can of course use a loop.
    – Bergi
    Nov 11 at 17:00












  • 1




    Your fetch only fetches pageitems (15) items? Is res.count the number of fetched records, or the total size of the data set at the backend?
    – trincot
    Nov 11 at 16:35







  • 2




    You can use async/await within a while loop. Or async/await is not an option here?
    – Sim Dim
    Nov 11 at 16:37






  • 2




    Warning: your code is calling fetch immediately, not when dbConnect resolves. You must put () => fetch(... there.
    – trincot
    Nov 11 at 16:40







  • 2




    Yes, recursion is the way to go. But just like in the non-promise case, for that you first need a function that you could call recursively.
    – Bergi
    Nov 11 at 16:43






  • 1




    @JonasWilms Sure, but it seems the OP tries to learn ES6 promise chaining first. My comment was just meant to be encouraging, that recursion is a correct approach, and the OP should try it. Later when adopting async/await you can of course use a loop.
    – Bergi
    Nov 11 at 17:00







1




1




Your fetch only fetches pageitems (15) items? Is res.count the number of fetched records, or the total size of the data set at the backend?
– trincot
Nov 11 at 16:35





Your fetch only fetches pageitems (15) items? Is res.count the number of fetched records, or the total size of the data set at the backend?
– trincot
Nov 11 at 16:35





2




2




You can use async/await within a while loop. Or async/await is not an option here?
– Sim Dim
Nov 11 at 16:37




You can use async/await within a while loop. Or async/await is not an option here?
– Sim Dim
Nov 11 at 16:37




2




2




Warning: your code is calling fetch immediately, not when dbConnect resolves. You must put () => fetch(... there.
– trincot
Nov 11 at 16:40





Warning: your code is calling fetch immediately, not when dbConnect resolves. You must put () => fetch(... there.
– trincot
Nov 11 at 16:40





2




2




Yes, recursion is the way to go. But just like in the non-promise case, for that you first need a function that you could call recursively.
– Bergi
Nov 11 at 16:43




Yes, recursion is the way to go. But just like in the non-promise case, for that you first need a function that you could call recursively.
– Bergi
Nov 11 at 16:43




1




1




@JonasWilms Sure, but it seems the OP tries to learn ES6 promise chaining first. My comment was just meant to be encouraging, that recursion is a correct approach, and the OP should try it. Later when adopting async/await you can of course use a loop.
– Bergi
Nov 11 at 17:00




@JonasWilms Sure, but it seems the OP tries to learn ES6 promise chaining first. My comment was just meant to be encouraging, that recursion is a correct approach, and the OP should try it. Later when adopting async/await you can of course use a loop.
– Bergi
Nov 11 at 17:00












2 Answers
2






active

oldest

votes

















up vote
1
down vote



accepted










You could just use a regular loop:



 (async function() 
const conn = await dbConnect;
for(let offset = 0; true; offset++)
const data, count = await (await fetch(`api?page=$offset`)).json();
// Exit if the page is empty
if(count === 0) break;
await collection.insertMany(data, ordered: false );

)();


To speed that up you could execute multiple requests in parallel:



 const chunkSize = 10; // 10 in parallel
for(let offset = 0; offset < chunkSize; offset++)
(async function()
const conn = await dbConnect;
for(let offset2 = 0; true; offset2 += chunkSize)
const data, count = await (await fetch(`api?page=$offset + offset2`)).json();
// Exit if the page is empty
if(count === 0) break;
await collection.insertMany(data, ordered: false );

)();






share|improve this answer




















  • this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
    – Himmators
    Nov 11 at 21:10






  • 1




    @himmators definetly depends on the usecase, glad to help :)
    – Jonas Wilms
    Nov 12 at 15:47

















up vote
1
down vote













Basically, you will want to wrap your fetch and insert into a function that you will call many times. See the below as an example to illustrate my point...



let db;
let pageitems = 35
var offset = 0;


var db = dbConnect() //establish connection to database

function fetch_and_insert(offset)
db
.then(fetch(apiLink + "?" + offset))
.then(res => res.json())
.then(res =>
var total = res.count
collection.insertMany(res.data, ordered: false )
.catch(err =>
if (err.code !== 11000) log(err)
else
log(
completed: err.result.nInserted, duplicates: err.result.result.writeErrors.length
);

)
if (offset < total) return fetch_and_insert(offset + pageitems)
return null;
)


fetch_and_insert(offset)
.then(() =>
connection.close();
)





share|improve this answer




















    Your Answer






    StackExchange.ifUsing("editor", function ()
    StackExchange.using("externalEditor", function ()
    StackExchange.using("snippets", function ()
    StackExchange.snippets.init();
    );
    );
    , "code-snippets");

    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "1"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53250797%2fhow-can-i-use-loops-recursion-with-promise-chains%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    2 Answers
    2






    active

    oldest

    votes








    2 Answers
    2






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes








    up vote
    1
    down vote



    accepted










    You could just use a regular loop:



     (async function() 
    const conn = await dbConnect;
    for(let offset = 0; true; offset++)
    const data, count = await (await fetch(`api?page=$offset`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();


    To speed that up you could execute multiple requests in parallel:



     const chunkSize = 10; // 10 in parallel
    for(let offset = 0; offset < chunkSize; offset++)
    (async function()
    const conn = await dbConnect;
    for(let offset2 = 0; true; offset2 += chunkSize)
    const data, count = await (await fetch(`api?page=$offset + offset2`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();






    share|improve this answer




















    • this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
      – Himmators
      Nov 11 at 21:10






    • 1




      @himmators definetly depends on the usecase, glad to help :)
      – Jonas Wilms
      Nov 12 at 15:47














    up vote
    1
    down vote



    accepted










    You could just use a regular loop:



     (async function() 
    const conn = await dbConnect;
    for(let offset = 0; true; offset++)
    const data, count = await (await fetch(`api?page=$offset`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();


    To speed that up you could execute multiple requests in parallel:



     const chunkSize = 10; // 10 in parallel
    for(let offset = 0; offset < chunkSize; offset++)
    (async function()
    const conn = await dbConnect;
    for(let offset2 = 0; true; offset2 += chunkSize)
    const data, count = await (await fetch(`api?page=$offset + offset2`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();






    share|improve this answer




















    • this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
      – Himmators
      Nov 11 at 21:10






    • 1




      @himmators definetly depends on the usecase, glad to help :)
      – Jonas Wilms
      Nov 12 at 15:47












    up vote
    1
    down vote



    accepted







    up vote
    1
    down vote



    accepted






    You could just use a regular loop:



     (async function() 
    const conn = await dbConnect;
    for(let offset = 0; true; offset++)
    const data, count = await (await fetch(`api?page=$offset`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();


    To speed that up you could execute multiple requests in parallel:



     const chunkSize = 10; // 10 in parallel
    for(let offset = 0; offset < chunkSize; offset++)
    (async function()
    const conn = await dbConnect;
    for(let offset2 = 0; true; offset2 += chunkSize)
    const data, count = await (await fetch(`api?page=$offset + offset2`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();






    share|improve this answer












    You could just use a regular loop:



     (async function() 
    const conn = await dbConnect;
    for(let offset = 0; true; offset++)
    const data, count = await (await fetch(`api?page=$offset`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();


    To speed that up you could execute multiple requests in parallel:



     const chunkSize = 10; // 10 in parallel
    for(let offset = 0; offset < chunkSize; offset++)
    (async function()
    const conn = await dbConnect;
    for(let offset2 = 0; true; offset2 += chunkSize)
    const data, count = await (await fetch(`api?page=$offset + offset2`)).json();
    // Exit if the page is empty
    if(count === 0) break;
    await collection.insertMany(data, ordered: false );

    )();







    share|improve this answer












    share|improve this answer



    share|improve this answer










    answered Nov 11 at 16:45









    Jonas Wilms

    53.5k42547




    53.5k42547











    • this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
      – Himmators
      Nov 11 at 21:10






    • 1




      @himmators definetly depends on the usecase, glad to help :)
      – Jonas Wilms
      Nov 12 at 15:47
















    • this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
      – Himmators
      Nov 11 at 21:10






    • 1




      @himmators definetly depends on the usecase, glad to help :)
      – Jonas Wilms
      Nov 12 at 15:47















    this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
    – Himmators
    Nov 11 at 21:10




    this looks nice, I have to read up on await/async more...(though I don't want to call them all at once, I think the API will hate me if I do and it's a scrape anyways...)
    – Himmators
    Nov 11 at 21:10




    1




    1




    @himmators definetly depends on the usecase, glad to help :)
    – Jonas Wilms
    Nov 12 at 15:47




    @himmators definetly depends on the usecase, glad to help :)
    – Jonas Wilms
    Nov 12 at 15:47












    up vote
    1
    down vote













    Basically, you will want to wrap your fetch and insert into a function that you will call many times. See the below as an example to illustrate my point...



    let db;
    let pageitems = 35
    var offset = 0;


    var db = dbConnect() //establish connection to database

    function fetch_and_insert(offset)
    db
    .then(fetch(apiLink + "?" + offset))
    .then(res => res.json())
    .then(res =>
    var total = res.count
    collection.insertMany(res.data, ordered: false )
    .catch(err =>
    if (err.code !== 11000) log(err)
    else
    log(
    completed: err.result.nInserted, duplicates: err.result.result.writeErrors.length
    );

    )
    if (offset < total) return fetch_and_insert(offset + pageitems)
    return null;
    )


    fetch_and_insert(offset)
    .then(() =>
    connection.close();
    )





    share|improve this answer
























      up vote
      1
      down vote













      Basically, you will want to wrap your fetch and insert into a function that you will call many times. See the below as an example to illustrate my point...



      let db;
      let pageitems = 35
      var offset = 0;


      var db = dbConnect() //establish connection to database

      function fetch_and_insert(offset)
      db
      .then(fetch(apiLink + "?" + offset))
      .then(res => res.json())
      .then(res =>
      var total = res.count
      collection.insertMany(res.data, ordered: false )
      .catch(err =>
      if (err.code !== 11000) log(err)
      else
      log(
      completed: err.result.nInserted, duplicates: err.result.result.writeErrors.length
      );

      )
      if (offset < total) return fetch_and_insert(offset + pageitems)
      return null;
      )


      fetch_and_insert(offset)
      .then(() =>
      connection.close();
      )





      share|improve this answer






















        up vote
        1
        down vote










        up vote
        1
        down vote









        Basically, you will want to wrap your fetch and insert into a function that you will call many times. See the below as an example to illustrate my point...



        let db;
        let pageitems = 35
        var offset = 0;


        var db = dbConnect() //establish connection to database

        function fetch_and_insert(offset)
        db
        .then(fetch(apiLink + "?" + offset))
        .then(res => res.json())
        .then(res =>
        var total = res.count
        collection.insertMany(res.data, ordered: false )
        .catch(err =>
        if (err.code !== 11000) log(err)
        else
        log(
        completed: err.result.nInserted, duplicates: err.result.result.writeErrors.length
        );

        )
        if (offset < total) return fetch_and_insert(offset + pageitems)
        return null;
        )


        fetch_and_insert(offset)
        .then(() =>
        connection.close();
        )





        share|improve this answer












        Basically, you will want to wrap your fetch and insert into a function that you will call many times. See the below as an example to illustrate my point...



        let db;
        let pageitems = 35
        var offset = 0;


        var db = dbConnect() //establish connection to database

        function fetch_and_insert(offset)
        db
        .then(fetch(apiLink + "?" + offset))
        .then(res => res.json())
        .then(res =>
        var total = res.count
        collection.insertMany(res.data, ordered: false )
        .catch(err =>
        if (err.code !== 11000) log(err)
        else
        log(
        completed: err.result.nInserted, duplicates: err.result.result.writeErrors.length
        );

        )
        if (offset < total) return fetch_and_insert(offset + pageitems)
        return null;
        )


        fetch_and_insert(offset)
        .then(() =>
        connection.close();
        )






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 11 at 16:42









        Paul

        3,71922238




        3,71922238



























            draft saved

            draft discarded
















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53250797%2fhow-can-i-use-loops-recursion-with-promise-chains%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Top Tejano songwriter Luis Silva dead of heart attack at 64

            政党

            天津地下鉄3号線