JavaScript slow and not DRY
up vote
2
down vote
favorite
I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);
$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);
$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
javascript jquery
add a comment |
up vote
2
down vote
favorite
I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);
$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);
$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
javascript jquery
Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30
add a comment |
up vote
2
down vote
favorite
up vote
2
down vote
favorite
I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);
$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);
$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
javascript jquery
I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);
$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);
$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
javascript jquery
javascript jquery
asked Nov 11 at 16:27
Jon Programmer
2228
2228
Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30
add a comment |
Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30
Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30
Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30
add a comment |
1 Answer
1
active
oldest
votes
up vote
2
down vote
accepted
Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler
):
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();
$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));
$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));
$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
add a comment |
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
2
down vote
accepted
Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler
):
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();
$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));
$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));
$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
add a comment |
up vote
2
down vote
accepted
Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler
):
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();
$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));
$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));
$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
add a comment |
up vote
2
down vote
accepted
up vote
2
down vote
accepted
Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler
):
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();
$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));
$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));
$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler
):
<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();
);
// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();
$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));
$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));
$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));
// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>
answered Nov 11 at 16:41
Ollin Boer Bohan
1,365310
1,365310
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
add a comment |
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53250767%2fjavascript-slow-and-not-dry%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30