JavaScript slow and not DRY









up vote
2
down vote

favorite












I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);

$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);

$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>









share|improve this question





















  • Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
    – Bergi
    Nov 11 at 16:30














up vote
2
down vote

favorite












I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);

$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);

$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>









share|improve this question





















  • Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
    – Bergi
    Nov 11 at 16:30












up vote
2
down vote

favorite









up vote
2
down vote

favorite











I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);

$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);

$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>









share|improve this question













I am using this JavaScript code here to handle different checkout boxes via Stripe on my page. My code seems to slow down my page. When I clicked the button, it takes 3-5 seconds to open the Checkout box. Also what I use here doesn't look DRY. Do you have a better way to write this code shorter?



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

$('#buyCourseButton1').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '4900'
);
$('#coursePackage').val('package_1');
e.preventDefault();
);

$('#buyCourseButton2').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '9900'
);
$('#coursePackage').val('package_2');
e.preventDefault();
);

$('#buyCourseButton3').click(function(e)
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: '79900'
);
$('#coursePackage').val('package_3');
e.preventDefault();
);

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>






javascript jquery






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 11 at 16:27









Jon Programmer

2228




2228











  • Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
    – Bergi
    Nov 11 at 16:30
















  • Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
    – Bergi
    Nov 11 at 16:30















Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30




Put the similar code in a function (with the parts that differ as parameters) and call that function multiple times.
– Bergi
Nov 11 at 16:30












1 Answer
1






active

oldest

votes

















up vote
2
down vote



accepted










Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler):



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();



$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));

$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));

$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>





share|improve this answer




















  • Works perfect! Thank you
    – Jon Programmer
    Nov 11 at 18:33










Your Answer






StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);













draft saved

draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53250767%2fjavascript-slow-and-not-dry%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes








up vote
2
down vote



accepted










Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler):



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();



$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));

$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));

$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>





share|improve this answer




















  • Works perfect! Thank you
    – Jon Programmer
    Nov 11 at 18:33














up vote
2
down vote



accepted










Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler):



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();



$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));

$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));

$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>





share|improve this answer




















  • Works perfect! Thank you
    – Jon Programmer
    Nov 11 at 18:33












up vote
2
down vote



accepted







up vote
2
down vote



accepted






Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler):



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();



$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));

$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));

$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>





share|improve this answer












Here's a quick refactor that moves the click handler generation to a helper function (courseClickHandler):



<script>
var handler = StripeCheckout.configure(
key: ' stripe_pub_key ',
image: '% static "img/payment/paul.jpg" %',
locale: 'auto',
allowRememberMe: false,
zipCode: true,
token: function(token)
$('#stripeToken').val(token.id);
$('#stripeEmail').val(token.email);
$('#paymentForm').submit();

);

// create a new click event handler for the given course package,
// and the given amount
var courseClickHandler = (amount, coursePackage) =>
return e =>
// Open Checkout with further options:
handler.open(
name: 'Brand You',
description: 'by Paul S.',
currency: 'eur',
amount: amount
);
$('#coursePackage').val(coursePackage);
e.preventDefault();



$('#buyCourseButton1').click(courseClickHandler("4900", "package_1"));

$('#buyCourseButton2').click(courseClickHandler("9900", "package_2"));

$('#buyCourseButton3').click(courseClickHandler("79900", "package_3"));

// Close Checkout on page navigation:
window.addEventListener('popstate', function()
handler.close();
);
</script>






share|improve this answer












share|improve this answer



share|improve this answer










answered Nov 11 at 16:41









Ollin Boer Bohan

1,365310




1,365310











  • Works perfect! Thank you
    – Jon Programmer
    Nov 11 at 18:33
















  • Works perfect! Thank you
    – Jon Programmer
    Nov 11 at 18:33















Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33




Works perfect! Thank you
– Jon Programmer
Nov 11 at 18:33

















draft saved

draft discarded
















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53250767%2fjavascript-slow-and-not-dry%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Top Tejano songwriter Luis Silva dead of heart attack at 64

政党

天津地下鉄3号線