How to push a string in stack?
0
How to push a string in stack,
I have used these structures to develop a stack to store students details and their marks,
typedef struct node
char name[50];
int marks;
struct node * next;
Node;
typedef struct
int no_student;
Node * top;
stack;
My Push function to push his name and marks into the stack is below,
void Push(stack *S, char name, int marks)
Node *np;
np = (Node*)malloc(sizeof(Node));
np->marks = marks;
strcpy(S->top->name, name);
np->next = S->top;
S->top = np;
S->no_student++;
When I run this code, Compiler giving me a run time error, How can I fix this?
c string stack push
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
|
show 7 more comments
0
How to push a string in stack,
I have used these structures to develop a stack to store students details and their marks,
typedef struct node
char name[50];
int marks;
struct node * next;
Node;
typedef struct
int no_student;
Node * top;
stack;
My Push function to push his name and marks into the stack is below,
void Push(stack *S, char name, int marks)
Node *np;
np = (Node*)malloc(sizeof(Node));
np->marks = marks;
strcpy(S->top->name, name);
np->next = S->top;
S->top = np;
S->no_student++;
When I run this code, Compiler giving me a run time error, How can I fix this?
c string stack push
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
2
sizeof(np)is the size of the pointernp, not the structure it (will) point to. You need to usesizeof *np.
– Some programmer dude
Nov 12 at 9:27
1
There are other problems with your code as well, I suggest you do some rubber duck debugging.
– Some programmer dude
Nov 12 at 9:29
1
This looks more like a linked list than a stack IMHO.
– babon
Nov 12 at 9:29
1
@babon Linked lists are the simplest way of creating a stack without specific limits.
– Some programmer dude
Nov 12 at 9:33
1
strcpy(S->top->name, name);shouldn't bestrcpy(np->name, name);? Trying to copy new name on old top of stack will fail at beginning when the stack is empty andS->top==NULL.
– Frankie_C
Nov 12 at 9:54
|
show 7 more comments
0
0
0
How to push a string in stack,
I have used these structures to develop a stack to store students details and their marks,
typedef struct node
char name[50];
int marks;
struct node * next;
Node;
typedef struct
int no_student;
Node * top;
stack;
My Push function to push his name and marks into the stack is below,
void Push(stack *S, char name, int marks)
Node *np;
np = (Node*)malloc(sizeof(Node));
np->marks = marks;
strcpy(S->top->name, name);
np->next = S->top;
S->top = np;
S->no_student++;
When I run this code, Compiler giving me a run time error, How can I fix this?
c string stack push
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
How to push a string in stack,
I have used these structures to develop a stack to store students details and their marks,
typedef struct node
char name[50];
int marks;
struct node * next;
Node;
typedef struct
int no_student;
Node * top;
stack;
My Push function to push his name and marks into the stack is below,
void Push(stack *S, char name, int marks)
Node *np;
np = (Node*)malloc(sizeof(Node));
np->marks = marks;
strcpy(S->top->name, name);
np->next = S->top;
S->top = np;
S->no_student++;
When I run this code, Compiler giving me a run time error, How can I fix this?
c string stack push
c string stack push
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
edited Nov 12 at 9:29
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
asked Nov 12 at 9:25
AS Mohamed Faheem Anver
229
229
2
sizeof(np)is the size of the pointernp, not the structure it (will) point to. You need to usesizeof *np.
– Some programmer dude
Nov 12 at 9:27
1
There are other problems with your code as well, I suggest you do some rubber duck debugging.
– Some programmer dude
Nov 12 at 9:29
1
This looks more like a linked list than a stack IMHO.
– babon
Nov 12 at 9:29
1
@babon Linked lists are the simplest way of creating a stack without specific limits.
– Some programmer dude
Nov 12 at 9:33
1
strcpy(S->top->name, name);shouldn't bestrcpy(np->name, name);? Trying to copy new name on old top of stack will fail at beginning when the stack is empty andS->top==NULL.
– Frankie_C
Nov 12 at 9:54
|
show 7 more comments
2
sizeof(np)is the size of the pointernp, not the structure it (will) point to. You need to usesizeof *np.
– Some programmer dude
Nov 12 at 9:27
1
There are other problems with your code as well, I suggest you do some rubber duck debugging.
– Some programmer dude
Nov 12 at 9:29
1
This looks more like a linked list than a stack IMHO.
– babon
Nov 12 at 9:29
1
@babon Linked lists are the simplest way of creating a stack without specific limits.
– Some programmer dude
Nov 12 at 9:33
1
strcpy(S->top->name, name);shouldn't bestrcpy(np->name, name);? Trying to copy new name on old top of stack will fail at beginning when the stack is empty andS->top==NULL.
– Frankie_C
Nov 12 at 9:54
2
2
sizeof(np) is the size of the pointer np, not the structure it (will) point to. You need to use sizeof *np.– Some programmer dude
Nov 12 at 9:27
sizeof(np) is the size of the pointer np, not the structure it (will) point to. You need to use sizeof *np.– Some programmer dude
Nov 12 at 9:27
1
1
There are other problems with your code as well, I suggest you do some rubber duck debugging.
– Some programmer dude
Nov 12 at 9:29
There are other problems with your code as well, I suggest you do some rubber duck debugging.
– Some programmer dude
Nov 12 at 9:29
1
1
This looks more like a linked list than a stack IMHO.
– babon
Nov 12 at 9:29
This looks more like a linked list than a stack IMHO.
– babon
Nov 12 at 9:29
1
1
@babon Linked lists are the simplest way of creating a stack without specific limits.
– Some programmer dude
Nov 12 at 9:33
@babon Linked lists are the simplest way of creating a stack without specific limits.
– Some programmer dude
Nov 12 at 9:33
1
1
strcpy(S->top->name, name); shouldn't be strcpy(np->name, name);? Trying to copy new name on old top of stack will fail at beginning when the stack is empty and S->top==NULL.– Frankie_C
Nov 12 at 9:54
strcpy(S->top->name, name); shouldn't be strcpy(np->name, name);? Trying to copy new name on old top of stack will fail at beginning when the stack is empty and S->top==NULL.– Frankie_C
Nov 12 at 9:54
|
show 7 more comments
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53259166%2fhow-to-push-a-string-in-stack%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53259166%2fhow-to-push-a-string-in-stack%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
2
sizeof(np)is the size of the pointernp, not the structure it (will) point to. You need to usesizeof *np.– Some programmer dude
Nov 12 at 9:27
1
There are other problems with your code as well, I suggest you do some rubber duck debugging.
– Some programmer dude
Nov 12 at 9:29
1
This looks more like a linked list than a stack IMHO.
– babon
Nov 12 at 9:29
1
@babon Linked lists are the simplest way of creating a stack without specific limits.
– Some programmer dude
Nov 12 at 9:33
1
strcpy(S->top->name, name);shouldn't bestrcpy(np->name, name);? Trying to copy new name on old top of stack will fail at beginning when the stack is empty andS->top==NULL.– Frankie_C
Nov 12 at 9:54