Firebase Functions - Getting value from invalid reference not caught










0















I have two references like:



 var receiverMaleRef = admin.database().ref(`root/users/male/$currentUser`);
var receiverFemaleRef = admin.database().ref(`root/users/female/$currentUser`);


'currentUser' is unique overall i.e same name cannot exists on both nodes.



And I am using following code to get values:



return receiverMaleRef.once('value').then(function(maleDataSnapshot) 

)
.catch(err =>

//if currentUser is not male catch should be called because of invalid reference
//Get value from female node
return receiverFemaleRef.once('value').then(function(dataSnapshot)

)

);


The problem I am facing is if 'currentUser' is female it does not catches the error, instead it returns null in maleDataSnapshot.



What should be the workaround this issue?










share|improve this question


























    0















    I have two references like:



     var receiverMaleRef = admin.database().ref(`root/users/male/$currentUser`);
    var receiverFemaleRef = admin.database().ref(`root/users/female/$currentUser`);


    'currentUser' is unique overall i.e same name cannot exists on both nodes.



    And I am using following code to get values:



    return receiverMaleRef.once('value').then(function(maleDataSnapshot) 

    )
    .catch(err =>

    //if currentUser is not male catch should be called because of invalid reference
    //Get value from female node
    return receiverFemaleRef.once('value').then(function(dataSnapshot)

    )

    );


    The problem I am facing is if 'currentUser' is female it does not catches the error, instead it returns null in maleDataSnapshot.



    What should be the workaround this issue?










    share|improve this question
























      0












      0








      0








      I have two references like:



       var receiverMaleRef = admin.database().ref(`root/users/male/$currentUser`);
      var receiverFemaleRef = admin.database().ref(`root/users/female/$currentUser`);


      'currentUser' is unique overall i.e same name cannot exists on both nodes.



      And I am using following code to get values:



      return receiverMaleRef.once('value').then(function(maleDataSnapshot) 

      )
      .catch(err =>

      //if currentUser is not male catch should be called because of invalid reference
      //Get value from female node
      return receiverFemaleRef.once('value').then(function(dataSnapshot)

      )

      );


      The problem I am facing is if 'currentUser' is female it does not catches the error, instead it returns null in maleDataSnapshot.



      What should be the workaround this issue?










      share|improve this question














      I have two references like:



       var receiverMaleRef = admin.database().ref(`root/users/male/$currentUser`);
      var receiverFemaleRef = admin.database().ref(`root/users/female/$currentUser`);


      'currentUser' is unique overall i.e same name cannot exists on both nodes.



      And I am using following code to get values:



      return receiverMaleRef.once('value').then(function(maleDataSnapshot) 

      )
      .catch(err =>

      //if currentUser is not male catch should be called because of invalid reference
      //Get value from female node
      return receiverFemaleRef.once('value').then(function(dataSnapshot)

      )

      );


      The problem I am facing is if 'currentUser' is female it does not catches the error, instead it returns null in maleDataSnapshot.



      What should be the workaround this issue?







      firebase firebase-realtime-database google-cloud-functions






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 16 '18 at 5:19









      minimalistminimalist

      749




      749






















          1 Answer
          1






          active

          oldest

          votes


















          1














          If you want to catch the fact that maleDataSnapshot is null (i.e. does not exist) with your code you could use the exists() method and do as follows:



          return receiverMaleRef.once('value').then(function(maleDataSnapshot) 
          if (!maleDataSnapshot.exists())
          throw new Error('currentUser is not male');

          )
          .catch(err =>

          //if currentUser is not male catch should be called because of invalid reference
          //Get value from female node
          return receiverFemaleRef.once('value').then(function(dataSnapshot)

          )

          );


          However it is not really recommended to use error catching in order to implement your business logic. You may refactor your Cloud Function code with if/then/else. It is difficult to give an advice on how to do that without seeing the full code of the Cloud Function (i.e. overall logic, trigger type, what does it return at the end, etc.).






          share|improve this answer






















            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "1"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53331859%2ffirebase-functions-getting-value-from-invalid-reference-not-caught%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            1














            If you want to catch the fact that maleDataSnapshot is null (i.e. does not exist) with your code you could use the exists() method and do as follows:



            return receiverMaleRef.once('value').then(function(maleDataSnapshot) 
            if (!maleDataSnapshot.exists())
            throw new Error('currentUser is not male');

            )
            .catch(err =>

            //if currentUser is not male catch should be called because of invalid reference
            //Get value from female node
            return receiverFemaleRef.once('value').then(function(dataSnapshot)

            )

            );


            However it is not really recommended to use error catching in order to implement your business logic. You may refactor your Cloud Function code with if/then/else. It is difficult to give an advice on how to do that without seeing the full code of the Cloud Function (i.e. overall logic, trigger type, what does it return at the end, etc.).






            share|improve this answer



























              1














              If you want to catch the fact that maleDataSnapshot is null (i.e. does not exist) with your code you could use the exists() method and do as follows:



              return receiverMaleRef.once('value').then(function(maleDataSnapshot) 
              if (!maleDataSnapshot.exists())
              throw new Error('currentUser is not male');

              )
              .catch(err =>

              //if currentUser is not male catch should be called because of invalid reference
              //Get value from female node
              return receiverFemaleRef.once('value').then(function(dataSnapshot)

              )

              );


              However it is not really recommended to use error catching in order to implement your business logic. You may refactor your Cloud Function code with if/then/else. It is difficult to give an advice on how to do that without seeing the full code of the Cloud Function (i.e. overall logic, trigger type, what does it return at the end, etc.).






              share|improve this answer

























                1












                1








                1







                If you want to catch the fact that maleDataSnapshot is null (i.e. does not exist) with your code you could use the exists() method and do as follows:



                return receiverMaleRef.once('value').then(function(maleDataSnapshot) 
                if (!maleDataSnapshot.exists())
                throw new Error('currentUser is not male');

                )
                .catch(err =>

                //if currentUser is not male catch should be called because of invalid reference
                //Get value from female node
                return receiverFemaleRef.once('value').then(function(dataSnapshot)

                )

                );


                However it is not really recommended to use error catching in order to implement your business logic. You may refactor your Cloud Function code with if/then/else. It is difficult to give an advice on how to do that without seeing the full code of the Cloud Function (i.e. overall logic, trigger type, what does it return at the end, etc.).






                share|improve this answer













                If you want to catch the fact that maleDataSnapshot is null (i.e. does not exist) with your code you could use the exists() method and do as follows:



                return receiverMaleRef.once('value').then(function(maleDataSnapshot) 
                if (!maleDataSnapshot.exists())
                throw new Error('currentUser is not male');

                )
                .catch(err =>

                //if currentUser is not male catch should be called because of invalid reference
                //Get value from female node
                return receiverFemaleRef.once('value').then(function(dataSnapshot)

                )

                );


                However it is not really recommended to use error catching in order to implement your business logic. You may refactor your Cloud Function code with if/then/else. It is difficult to give an advice on how to do that without seeing the full code of the Cloud Function (i.e. overall logic, trigger type, what does it return at the end, etc.).







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 16 '18 at 8:18









                Renaud TarnecRenaud Tarnec

                12.6k21734




                12.6k21734





























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53331859%2ffirebase-functions-getting-value-from-invalid-reference-not-caught%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Top Tejano songwriter Luis Silva dead of heart attack at 64

                    政党

                    天津地下鉄3号線